Skip to content

Add support for public ecr #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add support for public ecr #391

wants to merge 3 commits into from

Conversation

fer1592
Copy link

@fer1592 fer1592 commented Jul 8, 2025 •
edited
Loading

Following PR adds support for images hosted in the AWS public registry, aims to solve the following issue. WIP

Add support for public ecr
c8be71c 
Signed-off-by: Fernando Perez Osan <[email protected]>
@fer1592 fer1592 requested a review from davidcollom as a code owner July 8, 2025 20:43
@fer1592 fer1592 marked this pull request as draft July 8, 2025 20:44
@fer1592 fer1592 mentioned this pull request Jul 8, 2025
Open
davidcollom
davidcollom reviewed Jul 9, 2025
View reviewed changes
Copy link
Collaborator

@davidcollom davidcollom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the draft PR 👍 - If you're looking for an existing public ECR - we have a deployed version-checker ECR for E2E testing @ public.ecr.aws/c3x5s3k7/public-8456b5e0/alpine which clones alpine:latest

@davidcollom davidcollom added the enhancement New feature or request label Jul 17, 2025
@fer1592
Copy link
Author

fer1592 commented Jul 25, 2025

Quick update about this, using the ecrpublic seems that doesn't work for images on the public.ecr.aws registry. I did a quick test using the http client similarly on how the docker client does, and works well. I'll be updating this PR next week probably (need to clean up all the crap code that I got)

@fer1592 fer1592 marked this pull request as ready for review August 8, 2025 20:09
@fer1592
Copy link
Author

fer1592 commented Aug 8, 2025 •
edited
Loading

This should be ready for review. Like mentioned before, I stopped using the public ecr library and just performed http requests for it. I tested it with a couple of images, and seems to be working fine. Eg: for kube-proxy

image

Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcollom davidcollom davidcollom left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fer1592 @davidcollom